WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75416
Move the remaining collections to caching on their respective base nodes.
https://bugs.webkit.org/show_bug.cgi?id=75416
Summary
Move the remaining collections to caching on their respective base nodes.
Andreas Kling
Reported
2012-01-01 11:27:17 PST
We should convert the remaining HTMLCollections to being cached on their respective base nodes.
Attachments
Patch
(27.65 KB, patch)
2012-01-01 12:46 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2012-01-01 12:46:46 PST
Created
attachment 120847
[details]
Patch
Andreas Kling
Comment 2
2012-01-01 13:05:52 PST
Comment on
attachment 120847
[details]
Patch Clearing flags on attachment: 120847 Committed
r103883
: <
http://trac.webkit.org/changeset/103883
>
Andreas Kling
Comment 3
2012-01-01 13:06:02 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4
2012-01-01 17:06:16 PST
Comment on
attachment 120847
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=120847&action=review
> LayoutTests/ChangeLog:8 > + - Updated gc-9.html to document the new lifetime behavior of HTMLCollections.
This change is not in the patch, and hasn't been landed.
Andreas Kling
Comment 5
2012-01-01 17:12:15 PST
(In reply to
comment #4
)
> (From update of
attachment 120847
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=120847&action=review
> > > LayoutTests/ChangeLog:8 > > + - Updated gc-9.html to document the new lifetime behavior of HTMLCollections. > > This change is not in the patch, and hasn't been landed.
Oops, I landed the missing gc-9.html update in <
http://trac.webkit.org/changeset/103886
> and forgot to note that here.
Ryosuke Niwa
Comment 6
2012-01-05 22:40:10 PST
It seems like this patch improved the dom perf by about 10%:
http://build.chromium.org/f/chromium/perf/mac-release-10.6/dom_perf/report.html?history=500&rev=116397
window is
http://trac.webkit.org/log/?action=stop_on_copy&mode=stop_on_copy&rev=103897&stop_rev=103871&limit=100&verbose=on
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug