Bug 75411 - Enable the [Supplemental] IDL on GTK/GObject
Summary: Enable the [Supplemental] IDL on GTK/GObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency tree / graph
 
Reported: 2011-12-31 16:47 PST by Kentaro Hara
Modified: 2012-01-02 17:25 PST (History)
4 users (show)

See Also:

Attachments
WIP patch to see if build passes (5.26 KB, patch)
2012-01-01 01:38 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-12-31 16:47:16 PST 
We have enabled the [Supplemental] IDL on Chromium, AppleWebKit, GTK, Qt, Efl and WinCE, and are planning to enable it on all platforms (Meta bug 72138). In this bug, we enable it on GTK/GObject.
Comment 1 Kentaro Hara 2012-01-01 01:38:23 PST 
Created attachment 120843 [details]
WIP patch to see if build passes
Comment 2 Adam Barth 2012-01-02 10:42:15 PST 
Comment on attachment 120843 [details]
WIP patch to see if build passes

View in context: https://bugs.webkit.org/attachment.cgi?id=120843&action=review

> Source/WebCore/bindings/gobject/GNUmakefile.am:467
> +	$(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/generate-bindings.pl --include $(WebCore)/dom --include $(WebCore)/html --include $(WebCore)/css --include $(WebCore)/page --include $(WebCore)/xml --include $(WebCore)/svg --outputDir "$(GENSOURCES_WEBKIT)" --defines "LANGUAGE_GOBJECT=1 $(gdom_feature_defines)" --generator GObject --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $<

I'm surprised that these includes aren't broken out into a variable, but I see that's how this script worked before.
Comment 3 WebKit Review Bot 2012-01-02 17:25:07 PST 
Comment on attachment 120843 [details]
WIP patch to see if build passes

Clearing flags on attachment: 120843

Committed r103920: <http://trac.webkit.org/changeset/103920>
Comment 4 WebKit Review Bot 2012-01-02 17:25:12 PST 
All reviewed patches have been landed.  Closing bug.