Bug 75364 - Use HashMap<OwnPtr> in RenderSVGResourceGradient
Summary: Use HashMap<OwnPtr> in RenderSVGResourceGradient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on: 75436
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-29 11:31 PST by Caio Marcelo de Oliveira Filho
Modified: 2012-01-03 11:08 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2011-12-29 11:36 PST, Caio Marcelo de Oliveira Filho 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-12-29 11:31:52 PST 
Use HashMap<OwnPtr> in RenderSVGResourceGradient
Comment 1 Caio Marcelo de Oliveira Filho 2011-12-29 11:36:28 PST 
Created attachment 120762 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2012-01-02 06:08:16 PST 
Committed r103905: <http://trac.webkit.org/changeset/103905>
Comment 3 Andrew Wilson 2012-01-03 09:45:01 PST 
We are seeing valgrind errors on the chromium bots that seem to be caused by this change - as an example:


   <insert_a_suppression_name_here>
   Memcheck:Uninitialized
   fun:_ZN7WebCore16SkPMColorToColorEj
   fun:_ZN7WebCore11ImageBuffer27platformTransformColorSpaceERKN3WTF6VectorIiLm0EEE
   fun:_ZN7WebCore11ImageBuffer19transformColorSpaceENS_10ColorSpaceES1_
   fun:_ZN7WebCore23RenderSVGResourceFilter17postApplyResourceEPNS_12RenderObjectERPNS_15GraphicsContextEtPKNS_4PathEPKNS_14RenderSVGShapeE
   fun:_ZN7WebCore16SVGRenderSupport22finishRenderSVGContentEPNS_12RenderObjectERNS_9PaintInfoEPNS_15GraphicsContextE
   fun:_ZN7WebCore14RenderSVGShape5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore9RenderBox5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore13RenderSVGRoot5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore9InlineBox5paintERNS_9PaintInfoERKNS_8IntPointEii
   fun:_ZN7WebCore13InlineFlowBox5paintERNS_9PaintInfoERKNS_8IntPointEii
   fun:_ZN7WebCore13RootInlineBox5paintERNS_9PaintInfoERKNS_8IntPointEii
   fun:_ZNK7WebCore17RenderLineBoxList5paintEPNS_20RenderBoxModelObjectERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintChildrenERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintChildrenERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE
}

Does this seem related?
Comment 4 Caio Marcelo de Oliveira Filho 2012-01-03 10:33:54 PST 
(In reply to comment #3)
> Does this seem related?

Doesn't seem directly related.

Which tests were run? How can I reproduce them in my machine (I have WebKit checkout compiled with --chromium)?

I read some instructions about tools/valgrind but couldn't find it inside the WebKit tree (even after running update-webkit --chromium).
Comment 5 Andrew Wilson 2012-01-03 11:08:36 PST 
It's not really possible to run valgrind from a webkit tree. OK, let's keep this resolved as "fixed" for now, and we'll see if the problem recurs or goes away in future valgrind build cycles - I'm not convinced that it's due to this change anyway).