Bug 75361 - Use HashMap<OwnPtr> in RenderSVGResourcePattern
Summary: Use HashMap<OwnPtr> in RenderSVGResourcePattern
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-29 10:03 PST by Caio Marcelo de Oliveira Filho
Modified: 2011-12-29 10:45 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2011-12-29 10:04 PST, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
Patch (4.06 KB, patch)
2011-12-29 10:36 PST, Caio Marcelo de Oliveira Filho 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-12-29 10:03:19 PST 
Use HashMap<OwnPtr> in RenderSVGResourcePattern
Comment 1 Caio Marcelo de Oliveira Filho 2011-12-29 10:04:38 PST 
Created attachment 120755 [details]
Patch
Comment 2 Andreas Kling 2011-12-29 10:08:41 PST 
Comment on attachment 120755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120755&action=review

> Source/WebCore/rendering/svg/RenderSVGResourcePattern.h:70
> -    HashMap<RenderObject*, PatternData*> m_pattern;
> +    HashMap<RenderObject*, OwnPtr<PatternData> > m_pattern;

m_pattern is not a great name for a hash map containing multiple patterns.
Comment 3 Caio Marcelo de Oliveira Filho 2011-12-29 10:36:30 PST 
Created attachment 120757 [details]
Patch
Comment 4 Caio Marcelo de Oliveira Filho 2011-12-29 10:45:09 PST 
Committed r103810: <http://trac.webkit.org/changeset/103810>