Bug 75346 - Use HashMap<OwnPtr> for SourceProviderCache items
Summary: Use HashMap<OwnPtr> for SourceProviderCache items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-29 05:26 PST by Caio Marcelo de Oliveira Filho
Modified: 2012-01-06 12:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.20 KB, patch)
2011-12-29 05:26 PST, Caio Marcelo de Oliveira Filho
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-12-29 05:26:17 PST
Use HashMap<OwnPtr> for SourceProviderCache items
Comment 1 Caio Marcelo de Oliveira Filho 2011-12-29 05:26:53 PST
Created attachment 120735 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2011-12-29 05:30:57 PST
I couldn't make it work just with the forward declaration to SourceProviderCacheItem.

I thought having the destructor for SourceProviderCache defined in the cpp would be enough, but in this case isn't. I think that's because the HashMap containing the OwnPtrs is a member itself -- c.f. the PageGroup that have the maps inside OwnPtrs. But I might be missing something.
Comment 3 Alexis Menard (darktears) 2012-01-02 12:47:19 PST
Comment on attachment 120735 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-01-06 12:20:42 PST
Comment on attachment 120735 [details]
Patch

Clearing flags on attachment: 120735

Committed r104318: <http://trac.webkit.org/changeset/104318>
Comment 5 WebKit Review Bot 2012-01-06 12:20:46 PST
All reviewed patches have been landed.  Closing bug.