Bug 75327 - Use HashMap<OwnPtr> in OriginAccessMap
Summary: Use HashMap<OwnPtr> in OriginAccessMap
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
Depends on: 75328
  Show dependency treegraph
Reported: 2011-12-28 14:35 PST by Caio Marcelo de Oliveira Filho
Modified: 2011-12-29 09:53 PST (History)
2 users (show)

See Also:

Patch (3.38 KB, patch)
2011-12-28 14:36 PST, Caio Marcelo de Oliveira Filho
no flags Details | Formatted Diff | Diff
Patch (3.38 KB, patch)
2011-12-29 04:47 PST, Caio Marcelo de Oliveira Filho
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-12-28 14:35:15 PST
Use HashMap<OwnPtr> in OriginAccessMap
Comment 1 Caio Marcelo de Oliveira Filho 2011-12-28 14:36:06 PST
Created attachment 120700 [details]
Comment 2 Caio Marcelo de Oliveira Filho 2011-12-28 14:44:10 PST
Committed r103782: <http://trac.webkit.org/changeset/103782>
Comment 3 Andrew Wilson 2011-12-28 15:31:40 PST
This patch seemed to cause crashes on the chromium bots:

2011-12-28 15:03:42,804 2698 single_test_runner.py:194 DEBUG worker/0 Stacktrace for http/tests/xmlhttprequest/origin-whitelisting-removal.html:
CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/get.txt. Origin is not allowed by Access-Control-Allow-Origin.
	base::debug::StackTrace::StackTrace() [0x5b6fee]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x59fe39]
	WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry() [0xd8eaea]
	WebKit::WebSecurityPolicy::removeOriginAccessWhitelistEntry() [0x46c50a]
	LayoutTestController::removeOriginAccessWhitelistEntry() [0x4335e0]
	CppBoundClass::invoke() [0x424548]
	WebCore::npObjectInvokeImpl() [0xb632e1]
	WebCore::npObjectMethodHandler() [0xb633ce]
	v8::internal::Builtin_HandleApiCall() [0x67d11d]

2011-12-28 15:03:42,805 2673 printing.py:462 INFO   http/tests/xmlhttprequest/origin-whitelisting-removal.html -> unexpected DumpRenderTree crash
2011-12-28 15:03:42,806 2698 worker.py:158 DEBUG worker/0 killing driver
2011-12-28 15:03:42,806 2698 worker.py:180 DEBUG worker/0 http/tests/xmlhttprequest/origin-whitelisting-removal.html failed:
2011-12-28 15:03:42,806 2698 worker.py:182 DEBUG worker/0  DumpRenderTree crashed
Comment 4 Caio Marcelo de Oliveira Filho 2011-12-29 04:47:24 PST
Reopening to attach new patch.
Comment 5 Caio Marcelo de Oliveira Filho 2011-12-29 04:47:28 PST
Created attachment 120732 [details]
Comment 6 Caio Marcelo de Oliveira Filho 2011-12-29 04:50:22 PST
Comment on attachment 120732 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=120732&action=review

> Source/WebCore/page/SecurityPolicy.cpp:-164
> -    delete list;

I've missed removing this delete in the first patch.
Comment 7 Caio Marcelo de Oliveira Filho 2011-12-29 09:53:50 PST
Committed r103807: <http://trac.webkit.org/changeset/103807>