V8CSSStyleDeclaration::namedPropertyQuery() always returns v8::Integer::New(v8::None) Regression from http://trac.webkit.org/changeset/102578
Patch to follow.
Created attachment 120667 [details] Patch
Upstreaming http://code.google.com/p/chromium/issues/detail?id=107941
Created attachment 120672 [details] [PATCH] Allow both 'webkit...' and 'Webkit...' prefixes for compatibility
Anton, can you have a look at the change please?
Comment on attachment 120672 [details] [PATCH] Allow both 'webkit...' and 'Webkit...' prefixes for compatibility Attachment 120672 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11036597 New failing tests: fast/dynamic/005.html
Created attachment 120684 [details] [PATCH] Fixed CSS property detection
Comment on attachment 120684 [details] [PATCH] Fixed CSS property detection View in context: https://bugs.webkit.org/attachment.cgi?id=120684&action=review > Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:185 > + CSSPropertyInfo* propertyInfo = cssPropertyInfo(v8Name); > + if (propertyInfo) We could combine these lines.
(In reply to comment #8) > (From update of attachment 120684 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120684&action=review > > > Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:185 > > + CSSPropertyInfo* propertyInfo = cssPropertyInfo(v8Name); > > + if (propertyInfo) > > We could combine these lines. Thanks Adam, will fix before landing!
Committed r103769: <http://trac.webkit.org/changeset/103769>
Comment on attachment 120684 [details] [PATCH] Fixed CSS property detection View in context: https://bugs.webkit.org/attachment.cgi?id=120684&action=review > Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:186 > + return v8::Integer::New(v8::None); just a question: is v8::None the best option? That's most probably is, but just double checking if those properties are enumerable and deletable?
Comment on attachment 120684 [details] [PATCH] Fixed CSS property detection View in context: https://bugs.webkit.org/attachment.cgi?id=120684&action=review >> Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:186 >> + return v8::Integer::New(v8::None); > > just a question: is v8::None the best option? That's most probably is, but just double checking if those properties are enumerable and deletable? That seems to be what we used to return earlier, before the fix.