Bug 75292 - [EFL] Move function to get dpi to the WebCore/platform/efl/EflScreenUtilities.cpp.
Summary: [EFL] Move function to get dpi to the WebCore/platform/efl/EflScreenUtilities...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-27 22:58 PST by Eunmi Lee
Modified: 2012-01-01 22:47 PST (History)
5 users (show)

See Also:


Attachments
patch for DPI (6.86 KB, patch)
2011-12-27 23:01 PST, Eunmi Lee
no flags Details | Formatted Diff | Diff
patch for DPI (6.98 KB, patch)
2011-12-28 18:47 PST, Eunmi Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eunmi Lee 2011-12-27 22:58:43 PST
Move ewk_util_dpi_get() function in the ewk_util.cpp to the WebCore/platform/efl/EflUtilities.cpp in order to use it in the WebKit2.
The function's name is changed to getDPI().
Comment 1 Eunmi Lee 2011-12-27 23:01:39 PST
Created attachment 120637 [details]
patch for DPI
Comment 2 Gyuyoung Kim 2011-12-27 23:28:33 PST
LGTM.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-12-28 04:34:17 PST
Comment on attachment 120637 [details]
patch for DPI

Looks OK; calling something 'utils', 'misc' or 'utilities' is something I'd like to avoid, though. As there is EflKeyboardUtilities.cpp, how about calling EflUtilities.cpp EflScreenUtilities.cpp?
Comment 4 Eunmi Lee 2011-12-28 18:06:12 PST
(In reply to comment #3)
> (From update of attachment 120637 [details])
> Looks OK; calling something 'utils', 'misc' or 'utilities' is something I'd like to avoid, though. As there is EflKeyboardUtilities.cpp, how about calling EflUtilities.cpp EflScreenUtilities.cpp?

I agree with you :)
It's better to use EflScreenUtilities.cpp as EflKeyboardUtilities.cpp.
Comment 5 Eunmi Lee 2011-12-28 18:47:32 PST
Created attachment 120712 [details]
patch for DPI

Rename EflUtilities.cpp to EflUtilities.h
Comment 6 Eunmi Lee 2011-12-28 18:48:03 PST
(In reply to comment #5)
> Created an attachment (id=120712) [details]
> patch for DPI
> 
> Rename EflUtilities.cpp to EflUtilities.h

Rename EflUtilities.cpp and EflUtilities.h to EflScreenUtilities.*
Comment 7 Gyuyoung Kim 2011-12-28 20:52:58 PST
Though I'm a little concern how many utilities files will be added, looks good. :-)
Comment 8 WebKit Review Bot 2012-01-01 22:47:01 PST
Comment on attachment 120712 [details]
patch for DPI

Clearing flags on attachment: 120712

Committed r103891: <http://trac.webkit.org/changeset/103891>
Comment 9 WebKit Review Bot 2012-01-01 22:47:06 PST
All reviewed patches have been landed.  Closing bug.