Bug 75287 – Add a new WTF::bind overload that takes 6 parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add a new WTF::bind overload that takes 6 parameters

[Anders Carlsson]

Created attachment 120627 [details]
Patch

[WebKit Review Bot]

Attachment 120627 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/Functional.h:284:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/JavaScriptCore/wtf/Functional.h:469:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/Functional.h:589:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 120627 [details]
Patch

Any way we can make a macro that can do this for us?

[Sam Weinig]

Created attachment 120681 [details]
Playing with macros

I took a stab at using macros to simulate some of the variadic templating.  Let me know how awful you think it is.

[Anders Carlsson]

(In reply to comment #4)
> Created an attachment (id=120681) [details]
> Playing with macros
> 
> I took a stab at using macros to simulate some of the variadic templating.  Let me know how awful you think it is.

It's pretty awful :)

What I'd like to do is have a variadic implementation in Functional.h and only use the gazillion specializations when the compiler doesn't support variadic templates. Something like

#if !COMPILER_SUPPORTS(CXX_VARIADIC_TEMPLATES)
#include "Functional.cxx98.h"
#else
// Real implementation
#endif

[Anders Carlsson]

Committed r103771: <http://trac.webkit.org/changeset/103771>