Bug 75279 – Crash in the WebKit accessibility code while attempting to retrieve the title UI element.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Ananta Iyengar]

We have been seeing this crash in Chromium with accessibility enabled. The chromium bug is here
http://crbug.com/108508(Logged against Chromeframe tests which enable webkit accessibility).

Debugging revealed that the crash occurs in the AccessibilityRenderObject::titleUIElement method
because of a NULL node being returned by the underlying RenderObject. Debugging this function
revealed that the RenderObject can return a NULL node pointer at times(if it is anonymous). 

We should check for a NULL node here.
Will upload a patch in a bit

[Ananta Iyengar]

Created attachment 120629 [details]
proposed patch

[Ryosuke Niwa]

Comment on attachment 120629 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120629&action=review

> Source/WebCore/ChangeLog:3
> +        https://bugs.webkit.org/show_bug.cgi?id=75279

You need to have a bug summary "Crash in the WebKit accessibility code while attempting to retrieve the title UI element." directly above the bug url. See other change log entries.

> Source/WebCore/ChangeLog:5
> +        Fix a crash in the the WebKit accessibility code which occurs while retrieving
> +        the title UI clement. The fix is to NULL check the RenderObject::node return value.

This line should appear below "Reviewed by" followed by a blank line. See other change log entries.

> Source/WebCore/ChangeLog:10
> +        No tests added as other functions in the AccessibilityRenderObject class NULL check
> +        the RenderObject::node return value.

Please explain why you're not adding a test instead of saying you're mimicking other null checks.

[Ananta Iyengar]

Created attachment 120630 [details]
proposed patch with description updated

[Ananta Iyengar]

Created attachment 120631 [details]
Patch with review comments addressed

[chris fleizach]

Comment on attachment 120631 [details]
Patch with review comments addressed

why is there no layout test for this one?

[chris fleizach]

you should be able to make this happen by inserting some html that will create an anonymous render block, and then ask for the title ui element of that anonymous element.

i'm tempted to review- this because there is no layout test

[WebKit Review Bot]

Comment on attachment 120631 [details]
Patch with review comments addressed

Clearing flags on attachment: 120631

Committed r103757: <http://trac.webkit.org/changeset/103757>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

(In reply to comment #5)
> (From update of attachment 120631 [details])
> why is there no layout test for this one?

This was causing some Chromium UI tests to fail but we didn't have a reduction in the form of a layout test. Ananta told me he's looking into creating a layout test next year.