Bug 75259 - Web Inspector: complete annotating SDK component.
Summary: Web Inspector: complete annotating SDK component.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-27 09:48 PST by Pavel Feldman
Modified: 2011-12-28 01:31 PST (History)
10 users (show)

See Also:


Attachments
Patch (23.64 KB, patch)
2011-12-27 09:50 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-12-27 09:48:01 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-12-27 09:50:03 PST
Created attachment 120597 [details]
Patch
Comment 2 Yury Semikhatsky 2011-12-27 11:30:35 PST
Comment on attachment 120597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120597&action=review

> Source/WebCore/inspector/front-end/NetworkManager.js:241
> +        if (!response)

Why did it change?
Comment 3 Pavel Feldman 2011-12-28 01:25:43 PST
Comment on attachment 120597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120597&action=review

>> Source/WebCore/inspector/front-end/NetworkManager.js:241
>> +        if (!response)
> 
> Why did it change?

It was wrong to require that the response is defined in the _isNull check. In fact, we are now sending 0 for null responses on the backend.
Comment 4 Pavel Feldman 2011-12-28 01:31:58 PST
Committed r103759: <http://trac.webkit.org/changeset/103759>