Bug 75245 - Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
Summary: Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-27 04:21 PST by Vsevolod Vlasov
Modified: 2011-12-27 08:23 PST (History)
10 users (show)

See Also:


Attachments
Patch (4.31 KB, patch)
2011-12-27 04:27 PST, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-12-27 04:21:05 PST
Scripts panel tabbed editor does not reopen closed tabs.
Comment 1 Vsevolod Vlasov 2011-12-27 04:27:20 PST
Created attachment 120576 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2011-12-27 04:37:42 PST
Comment on attachment 120576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120576&action=review

> Source/WebCore/inspector/front-end/TabbedPane.js:126
> +        var event = {tabId: id, view: tab.view, isUserGesture: userGesture};

we typically separate object contents by spaces inside braces: { tabId: ...  userGesture } - I remember getting a similar comment from Joe Pecoraro.
Comment 3 Pavel Feldman 2011-12-27 08:06:54 PST
Comment on attachment 120576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120576&action=review

>> Source/WebCore/inspector/front-end/TabbedPane.js:126
>> +        var event = {tabId: id, view: tab.view, isUserGesture: userGesture};
> 
> we typically separate object contents by spaces inside braces: { tabId: ...  userGesture } - I remember getting a similar comment from Joe Pecoraro.

var eventData = { ... } (it'll be event.data, not event).
Comment 4 Vsevolod Vlasov 2011-12-27 08:23:43 PST
Committed r103710: <http://trac.webkit.org/changeset/103710>