RESOLVED FIXED 75245
Web Inspector: Scripts panel tabbed editor does not reopen closed tabs. 
https://bugs.webkit.org/show_bug.cgi?id=75245
Summary Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
Vsevolod Vlasov
Reported 2011-12-27 04:21:05 PST
Scripts panel tabbed editor does not reopen closed tabs.
Attachments
Patch (4.31 KB, patch)
2011-12-27 04:27 PST, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-12-27 04:27:20 PST
Created attachment 120576 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2011-12-27 04:37:42 PST
Comment on attachment 120576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120576&action=review > Source/WebCore/inspector/front-end/TabbedPane.js:126 > + var event = {tabId: id, view: tab.view, isUserGesture: userGesture}; we typically separate object contents by spaces inside braces: { tabId: ... userGesture } - I remember getting a similar comment from Joe Pecoraro.
Pavel Feldman
Comment 3 2011-12-27 08:06:54 PST
Comment on attachment 120576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120576&action=review >> Source/WebCore/inspector/front-end/TabbedPane.js:126 >> + var event = {tabId: id, view: tab.view, isUserGesture: userGesture}; > > we typically separate object contents by spaces inside braces: { tabId: ... userGesture } - I remember getting a similar comment from Joe Pecoraro. var eventData = { ... } (it'll be event.data, not event).
Vsevolod Vlasov
Comment 4 2011-12-27 08:23:43 PST
Committed r103710: <http://trac.webkit.org/changeset/103710>
Note You need to log in before you can comment on or make changes to this bug.