Enabling DOWNLOAD_ATTRIBUTE feature so that it could initiate download directly if it has the attribute in the link and don't need to open new blank page for the target="_blank". Enabling this feature also prepare for later blob feature.
add cc
Created attachment 120567 [details] Patch
Comment on attachment 120567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120567&action=review Informal review. > ChangeLog:3 > + Enable DOWNLOAD_ATTRIBUTE in blackberry porting blackberry --> the BlackBerry? Also bug title? > Tools/ChangeLog:3 > + Enable DOWNLOAD_ATTRIBUTE in blackberry porting blackberry --> the BlackBerry? Also bug title? > Tools/Scripts/build-webkit:86 > $directoryUploadSupport, > + $downloadSupport, downloadSupport --> downloadAttributeSupport? > Tools/Scripts/build-webkit:143 > + { option => "download-attribute", desc => "Toggle download attribute support", > + define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(), value =>\$downloadSupport }, Ditto.
thanks, updating...
Created attachment 120569 [details] Patch
Comment on attachment 120569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120569&action=review > ChangeLog:7 > + Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting > + https://bugs.webkit.org/show_bug.cgi?id=75238 > + > + Reviewed by NOBODY (OOPS!). > + You guys do not write too much in changelogs :)
Thanks, Antonio, will update change log when commit...
Created attachment 121078 [details] Patch for landing
Comment on attachment 121078 [details] Patch for landing Clearing flags on attachment: 121078 Committed r104020: <http://trac.webkit.org/changeset/104020>
All reviewed patches have been landed. Closing bug.