Bug 75231 - Fail to throw in strict mode on assign to read only static properties
Summary: Fail to throw in strict mode on assign to read only static properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-26 16:27 PST by Gavin Barraclough
Modified: 2011-12-26 20:57 PST (History)
1 user (show)

See Also:


Attachments
Fix (14.87 KB, patch)
2011-12-26 16:31 PST, Gavin Barraclough
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-12-26 16:27:43 PST
Attempting to put to a readonly property should throw in strict mode, but we fail to do so for properties in static tables (e.g. values on Number, RegExp constructors). and static values in symbol tables of the variable objects (e.g. the global object's "undefined" property).
Comment 1 Gavin Barraclough 2011-12-26 16:31:22 PST
Created attachment 120560 [details]
Fix
Comment 2 WebKit Review Bot 2011-12-26 16:33:00 PST
Attachment 120560 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/JavaScriptCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-12-26 20:57:07 PST
Fixed in r103697