Bug 75229 - Web Inspector: Extract FileEditor from ScriptsPanel.
Summary: Web Inspector: Extract FileEditor from ScriptsPanel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks: 75093
  Show dependency treegraph
 
Reported: 2011-12-26 10:49 PST by Vsevolod Vlasov
Modified: 2011-12-26 11:47 PST (History)
10 users (show)

See Also:


Attachments
Patch (17.04 KB, patch)
2011-12-26 10:59 PST, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-12-26 10:49:44 PST
Extract FileEditor from ScriptsPanel.
Comment 1 Vsevolod Vlasov 2011-12-26 10:59:15 PST
Created attachment 120557 [details]
Patch
Comment 2 Pavel Feldman 2011-12-26 11:23:37 PST
Comment on attachment 120557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120557&action=review

Please rename new interface and a class prior to landing.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1073
> +WebInspector.ScriptsPanel.FileEditor = function() { }

FileEditor is not a great name for this. We have TextViewer (that was renamed from TextEditor when we stripped editing capabilities that should be renamed back). This looks like a WebInspector.EditorContainer to me.

> Source/WebCore/inspector/front-end/UISourceCode.js:145
> +        if (!this._fileName)

What if fileName is "" ?
Comment 3 Vsevolod Vlasov 2011-12-26 11:47:30 PST
Committed r103690: <http://trac.webkit.org/changeset/103690>