The current approach does not scale w.r.t. the number of different profile types ("Record" buttons.)
Created attachment 120593 [details] Patch
Comment on attachment 120593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120593&action=review Please remove welcome screen. > Source/WebCore/inspector/front-end/profilesPanel.css:150 > +.profile-launcher-view-content { Please reuse this style.
Created attachment 120656 [details] Patch
Comment on attachment 120656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120656&action=review > Source/WebCore/inspector/front-end/ProfileLauncherView.js:87 > + this.dispatchEventToListeners(WebInspector.ProfileLauncherView.EventTypes.ProfileTypeSelected, { profileType: profileType }); Why not to pass profileType as an event data instead? > Source/WebCore/inspector/front-end/ProfilesPanel.js:280 > + // Retain the profile type registration order in the tree, too. I don't think you need this logic. > Source/WebCore/inspector/front-end/ProfilesPanel.js:1032 > + onattach: function() Why do you need this override? > Source/WebCore/inspector/front-end/ProfilesPanel.js:1049 > + this.refreshTitles(); Where is this defined? Why doesn't it work be default?
Created attachment 120664 [details] Patch
Committed r103765: <http://trac.webkit.org/changeset/103765>