RESOLVED FIXED 75226
Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to Function" dialog item list 
https://bugs.webkit.org/show_bug.cgi?id=75226
Summary Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to...
Alexander Pavlov (apavlov)
Reported 2011-12-26 04:42:40 PST
Patch to follow.
Attachments
Patch (7.28 KB, patch)
2011-12-26 05:07 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] Comments addressed (9.64 KB, patch)
2011-12-26 06:24 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-12-26 05:07:48 PST
Created attachment 120550 [details] Patch
Pavel Feldman
Comment 2 2011-12-26 05:18:13 PST
Comment on attachment 120550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120550&action=review > Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:455 > + this._regExp = query ? this._dialog._createSearchRegExp(query, true) : null; this._regex > Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:475 > + if (this._highlightTimer) So is this this._timer or this._highlightTimer? > Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:483 > + const chunkSize = 50; It seems like computing visible range and highlighting it synchronously might require less code. > Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:499 > + var text = element._text; Could you use highlightRangesWithStyleClass instead?
Alexander Pavlov (apavlov)
Comment 3 2011-12-26 06:24:17 PST
Created attachment 120553 [details] [PATCH] Comments addressed
Pavel Feldman
Comment 4 2011-12-26 06:35:24 PST
Comment on attachment 120553 [details] [PATCH] Comments addressed View in context: https://bugs.webkit.org/attachment.cgi?id=120553&action=review > Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:232 > + this._startMatchHighlighting(); clearHighlight > Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:274 > + _startMatchHighlighting: function(query) inline > Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:465 > + start: function(query) highlightViewportItems
Alexander Pavlov (apavlov)
Comment 5 2011-12-26 07:06:59 PST
Committed: <http://trac.webkit.org/changeset/103684>
Note You need to log in before you can comment on or make changes to this bug.