Bug 75206 - Yarr: Avoid copying vectors in CharacterClassConstructor.
Summary: Yarr: Avoid copying vectors in CharacterClassConstructor.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-12-25 12:00 PST by Andreas Kling
Modified: 2011-12-25 13:21 PST (History)
2 users (show)

See Also:

Proposed patch (1.63 KB, patch)
2011-12-25 12:01 PST, Andreas Kling
darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-25 12:00:39 PST
CharacterClassConstructor::charClass() gets a little hot (1.2%) when loading twitter feeds, and we can avoid the copy altogether by using Vector::swap().
Comment 1 Andreas Kling 2011-12-25 12:01:42 PST
Created attachment 120512 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-12-25 12:54:05 PST
Comment on attachment 120512 [details]
Proposed patch

Attachment 120512 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11027710

New failing tests:
Comment 3 Andreas Kling 2011-12-25 13:21:20 PST
Committed r103672: <http://trac.webkit.org/changeset/103672>