Bug 75188 - RenderStyle: Inline the destructor.
Summary: RenderStyle: Inline the destructor.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-12-23 22:28 PST by Andreas Kling
Modified: 2011-12-24 12:22 PST (History)
1 user (show)

See Also:

Patch (1.92 KB, patch)
2011-12-23 22:32 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-23 22:28:26 PST
The empty RenderStyle destructor gets a little hot sometimes (0.4% on HTML5 spec load.) We should inline it to remove the function call.
Comment 1 Andreas Kling 2011-12-23 22:32:52 PST
Created attachment 120488 [details]
Comment 2 Andreas Kling 2011-12-24 10:32:15 PST
Comment on attachment 120488 [details]

Clearing flags on attachment: 120488

Committed r103656: <http://trac.webkit.org/changeset/103656>
Comment 3 Andreas Kling 2011-12-24 10:32:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Andreas Kling 2011-12-24 12:15:39 PST
Committed r103660: <http://trac.webkit.org/changeset/103660>
Comment 5 Darin Adler 2011-12-24 12:22:24 PST
Comment on attachment 120488 [details]

You could have just removed the declaration of ~RenderStyle altogether. I think that would be a bit more elegant and equally effective.