RESOLVED FIXED 75168
[TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision qualifier. 
https://bugs.webkit.org/show_bug.cgi?id=75168
Summary [TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision...
Dongseong Hwang
Reported 2011-12-23 03:40:50 PST
Some device supporting GLES2 will crash during compiling the TexMap fragment shader.
Attachments
patch (3.07 KB, patch)
2011-12-23 03:42 PST, Dongseong Hwang 		noam: review-
noam: commit-queue-
DetailsFormatted DiffDiff
patch (3.12 KB, patch)
2011-12-27 15:17 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2011-12-23 03:42:51 PST
Created attachment 120453 [details] patch
Noam Rosenthal
Comment 2 2011-12-27 15:02:29 PST
Comment on attachment 120453 [details] patch Please add "No new functionality so no new tests" to changelogs when applicable (like here).
Noam Rosenthal
Comment 3 2011-12-27 15:03:31 PST
Comment on attachment 120453 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 > +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION > #else > #define OES2_PRECISION_DEFINITIONS > +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION \ > + "precision mediump float; \n" Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one?
Dongseong Hwang
Comment 4 2011-12-27 15:05:31 PST
Comment on attachment 120453 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review >> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 >> + "precision mediump float; \n" > > Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one? It is because Vertex shader does not need the default precision qualifier.
Noam Rosenthal
Comment 5 2011-12-27 15:10:45 PST
(In reply to comment #4) > (From update of attachment 120453 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review > > >> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 > >> + "precision mediump float; \n" > > > > Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one? > > It is because Vertex shader does not need the default precision qualifier. Ah, ok. Please update the changelog (see previous comment) and I'll r+ it!
Dongseong Hwang
Comment 6 2011-12-27 15:17:30 PST
Created attachment 120620 [details] patch
WebKit Review Bot
Comment 7 2011-12-27 15:37:42 PST
Comment on attachment 120620 [details] patch Clearing flags on attachment: 120620 Committed r103735: <http://trac.webkit.org/changeset/103735>
WebKit Review Bot
Comment 8 2011-12-27 15:37:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.