Bug 75168 - [TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision qualifier.
Summary: [TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-23 03:40 PST by Dongseong Hwang
Modified: 2011-12-27 15:37 PST (History)
2 users (show)

See Also:


Attachments
patch (3.07 KB, patch)
2011-12-23 03:42 PST, Dongseong Hwang
noam: review-
noam: commit-queue-
Details | Formatted Diff | Diff
patch (3.12 KB, patch)
2011-12-27 15:17 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2011-12-23 03:40:50 PST
Some device supporting GLES2 will crash during compiling the TexMap fragment shader.
Comment 1 Dongseong Hwang 2011-12-23 03:42:51 PST
Created attachment 120453 [details]
patch
Comment 2 Noam Rosenthal 2011-12-27 15:02:29 PST
Comment on attachment 120453 [details]
patch

Please add "No new functionality so no new tests" to changelogs when applicable (like here).
Comment 3 Noam Rosenthal 2011-12-27 15:03:31 PST
Comment on attachment 120453 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317
> +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION
>  #else
>  #define OES2_PRECISION_DEFINITIONS
> +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION \
> +    "precision mediump float; \n"

Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one?
Comment 4 Dongseong Hwang 2011-12-27 15:05:31 PST
Comment on attachment 120453 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review

>> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317
>> +    "precision mediump float; \n"
> 
> Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one?

It is because Vertex shader does not need the default precision qualifier.
Comment 5 Noam Rosenthal 2011-12-27 15:10:45 PST
(In reply to comment #4)
> (From update of attachment 120453 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review
> 
> >> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317
> >> +    "precision mediump float; \n"
> > 
> > Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one?
> 
> It is because Vertex shader does not need the default precision qualifier.

Ah, ok.
Please update the changelog (see previous comment) and I'll r+ it!
Comment 6 Dongseong Hwang 2011-12-27 15:17:30 PST
Created attachment 120620 [details]
patch
Comment 7 WebKit Review Bot 2011-12-27 15:37:42 PST
Comment on attachment 120620 [details]
patch

Clearing flags on attachment: 120620

Committed r103735: <http://trac.webkit.org/changeset/103735>
Comment 8 WebKit Review Bot 2011-12-27 15:37:47 PST
All reviewed patches have been landed.  Closing bug.