Some device supporting GLES2 will crash during compiling the TexMap fragment shader.
Created attachment 120453 [details] patch
Comment on attachment 120453 [details] patch Please add "No new functionality so no new tests" to changelogs when applicable (like here).
Comment on attachment 120453 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 > +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION > #else > #define OES2_PRECISION_DEFINITIONS > +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION \ > + "precision mediump float; \n" Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one?
Comment on attachment 120453 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review >> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 >> + "precision mediump float; \n" > > Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one? It is because Vertex shader does not need the default precision qualifier.
(In reply to comment #4) > (From update of attachment 120453 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review > > >> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 > >> + "precision mediump float; \n" > > > > Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one? > > It is because Vertex shader does not need the default precision qualifier. Ah, ok. Please update the changelog (see previous comment) and I'll r+ it!
Created attachment 120620 [details] patch
Comment on attachment 120620 [details] patch Clearing flags on attachment: 120620 Committed r103735: <http://trac.webkit.org/changeset/103735>
All reviewed patches have been landed. Closing bug.