RESOLVED FIXED 75157
[EFL] Last parameter of ewk_view_scroll is always true. 
https://bugs.webkit.org/show_bug.cgi?id=75157
Summary [EFL] Last parameter of ewk_view_scroll is always true.
Ryuan Choi
Reported 2011-12-22 18:21:16 PST
ewk_view_scroll is only called by ChromeClient and last argument of it is always true. It started from initial drop and I don't know why this is needed.
Attachments
Patch (8.94 KB, patch)
2011-12-22 19:45 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-12-22 19:45:18 PST
Created attachment 120427 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-12-23 05:31:19 PST
(In reply to comment #0) > It started from initial drop and I don't know why this is needed. It looks like a sloppy API update -- see http://trac.webkit.org/changeset/58106. ChromeClient::scroll used to take an `isMainFrame` parameter which later got dropped. LGTM.
WebKit Review Bot
Comment 3 2011-12-26 20:38:52 PST
Comment on attachment 120427 [details] Patch Clearing flags on attachment: 120427 Committed r103696: <http://trac.webkit.org/changeset/103696>
WebKit Review Bot
Comment 4 2011-12-26 20:38:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.