Bug 75157 - [EFL] Last parameter of ewk_view_scroll is always true.
Summary: [EFL] Last parameter of ewk_view_scroll is always true.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-22 18:21 PST by Ryuan Choi
Modified: 2011-12-26 20:38 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.94 KB, patch)
2011-12-22 19:45 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-12-22 18:21:16 PST
ewk_view_scroll is only called by ChromeClient and last argument of it is always true.
It started from initial drop and I don't know why this is needed.
Comment 1 Ryuan Choi 2011-12-22 19:45:18 PST
Created attachment 120427 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-12-23 05:31:19 PST
(In reply to comment #0)
> It started from initial drop and I don't know why this is needed.

It looks like a sloppy API update -- see http://trac.webkit.org/changeset/58106. ChromeClient::scroll used to take an `isMainFrame` parameter which later got dropped.

LGTM.
Comment 3 WebKit Review Bot 2011-12-26 20:38:52 PST
Comment on attachment 120427 [details]
Patch

Clearing flags on attachment: 120427

Committed r103696: <http://trac.webkit.org/changeset/103696>
Comment 4 WebKit Review Bot 2011-12-26 20:38:56 PST
All reviewed patches have been landed.  Closing bug.