Bug 75151 - Add attributes field to JSArray's SparseMap
Summary: Add attributes field to JSArray's SparseMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-22 16:29 PST by Gavin Barraclough
Modified: 2011-12-23 14:51 PST (History)
1 user (show)

See Also:


Attachments
The patch (18.73 KB, patch)
2011-12-22 16:45 PST, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-12-22 16:29:11 PST
This will be necessary to be able to support non- writable/configurable/enumerable properties, and helpful for getters/setters.
Comment 1 Gavin Barraclough 2011-12-22 16:45:29 PST
Created attachment 120409 [details]
The patch
Comment 2 WebKit Review Bot 2011-12-22 16:46:51 PST
Attachment 120409 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/JSArray.cpp:451:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/JavaScriptCore/runtime/JSArray.cpp:452:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/JavaScriptCore/runtime/JSArray.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/runtime/JSArray.h:33:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-12-22 17:44:50 PST
Fixed in r 103598/103599
Comment 4 Sam Weinig 2011-12-23 14:51:37 PST
Comment on attachment 120409 [details]
The patch

I reviewed this.