WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
75147
Remove unused method and bogus comment from Attr
https://bugs.webkit.org/show_bug.cgi?id=75147
Summary
Remove unused method and bogus comment from Attr
Adam Klein
Reported
2011-12-22 15:56:19 PST
Remove unused method and bogus comment from Attr
Attachments
Patch
(2.09 KB, patch)
2011-12-22 15:57 PST
,
Adam Klein
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Klein
Comment 1
2011-12-22 15:57:56 PST
Created
attachment 120398
[details]
Patch
Ryosuke Niwa
Comment 2
2011-12-22 16:06:51 PST
Comment on
attachment 120398
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=120398&action=review
> Source/WebCore/dom/Attr.h:-37 > -// Attr can have Text and EntityReference children > -// therefore it has to be a fullblown Node. The plan > -// is to dynamically allocate a textchild and store the > -// resulting nodevalue in the Attribute upon > -// destruction. however, this is not yet implemented.
Wait, why is this comment bogus?
Collabora GTK+ EWS bot
Comment 3
2011-12-22 16:08:39 PST
Comment on
attachment 120398
[details]
Patch
Attachment 120398
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11020075
WebKit Review Bot
Comment 4
2011-12-22 16:09:46 PST
Comment on
attachment 120398
[details]
Patch
Attachment 120398
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/10955087
Adam Klein
Comment 5
2011-12-22 16:11:33 PST
Sigh, I don't know how I missed that this was in the IDL. Ignore.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug