Bug 75147 - Remove unused method and bogus comment from Attr
Summary: Remove unused method and bogus comment from Attr
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-22 15:56 PST by Adam Klein
Modified: 2011-12-22 16:11 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2011-12-22 15:57 PST, Adam Klein 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-12-22 15:56:19 PST 
Remove unused method and bogus comment from Attr
Comment 1 Adam Klein 2011-12-22 15:57:56 PST 
Created attachment 120398 [details]
Patch
Comment 2 Ryosuke Niwa 2011-12-22 16:06:51 PST 
Comment on attachment 120398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120398&action=review

> Source/WebCore/dom/Attr.h:-37
> -// Attr can have Text and EntityReference children
> -// therefore it has to be a fullblown Node. The plan
> -// is to dynamically allocate a textchild and store the
> -// resulting nodevalue in the Attribute upon
> -// destruction. however, this is not yet implemented.

Wait, why is this comment bogus?
Comment 3 Collabora GTK+ EWS bot 2011-12-22 16:08:39 PST 
Comment on attachment 120398 [details]
Patch

Attachment 120398 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11020075
Comment 4 WebKit Review Bot 2011-12-22 16:09:46 PST 
Comment on attachment 120398 [details]
Patch

Attachment 120398 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10955087
Comment 5 Adam Klein 2011-12-22 16:11:33 PST 
Sigh, I don't know how I missed that this was in the IDL.  Ignore.