Run tests in serial on SnowLeopard to avoid CFURLCache crashes

[Simon Fraser (smfr)]

CFURLCache seems to have issues when lots of processes are hitting the same cache. We should run the tests in serial on SnowLeopard to avoid this. See bug 75131

[Eric Seidel (no email)]

Sad times.  I assume there is a radar about the crash?  Or I guess one isn't needed since SL is history now...

Do you know if only some of the tests crash?  Can we run just those in serial?

[Simon Fraser (smfr)]

I was crashing just running fast/

There is a radar.

[Eric Seidel (no email)]

mac.py:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py

Should override default_child_processes:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L166

to be 1 on SnowLeopard if it detects that this bug is present (or I guess always if the bug is always present).

Alternatively, Mac.__init__ could use set_default("child_processes", 1) like it does for batch_size.  I'm not really sure which is cleaner.

[Dirk Pranke]

overridding default_child_processes would be the recommended way to do it.

[Eric Seidel (no email)]

Created attachment 125196 [details]
Patch

[Eric Seidel (no email)]

Created attachment 125198 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 125198 [details]
Patch for landing

Clearing flags on attachment: 125198

Committed r106616: <http://trac.webkit.org/changeset/106616>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.