RESOLVED FIXED 75130
Crash and incorrect behavior when switching between hardware and software CSS filters
https://bugs.webkit.org/show_bug.cgi?id=75130
Summary Crash and incorrect behavior when switching between hardware and software CSS...
Chris Marrin
Reported 2011-12-22 15:01:06 PST
Open the attached test case and rollover any image. The image will switch to using hardware filters and you may see a slight change in the image. Now roll off and you will crash. Crash is happening in RenderLayer.cpp around 2791 because m_filter is NULL and gets dereferenced. I tried adding a check for a null pointer to the enclosing if statement and that caused the crash to go away, but then rolling off the image caused it to not have a filter at all. It should revert to the software filter.
Attachments
Test case showing bug (552 bytes, text/html)
2011-12-22 16:14 PST, Chris Marrin
no flags
Patch (4.47 KB, patch)
2011-12-22 16:48 PST, Chris Marrin
simon.fraser: review+
Chris Marrin
Comment 1 2011-12-22 16:14:08 PST
Created attachment 120401 [details] Test case showing bug
Chris Marrin
Comment 2 2011-12-22 16:48:12 PST
Simon Fraser (smfr)
Comment 3 2011-12-22 16:55:43 PST
Comment on attachment 120410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120410&action=review > LayoutTests/css3/filters/crash-hw-sw-switch-expected.txt:1 > + It would be nice if the expected output were "This test should not crash" or some such.
Chris Marrin
Comment 4 2011-12-22 17:09:11 PST
Note You need to log in before you can comment on or make changes to this bug.