WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75128
Radio buttons cut in download movie sheet
https://bugs.webkit.org/show_bug.cgi?id=75128
Summary
Radio buttons cut in download movie sheet
Jon Lee
Reported
2011-12-22 14:37:02 PST
<
rdar://problem/9399450
> depending on the css size of the form element, the button gets clipped when compositing is on. test case: <body style="-webkit-transform:translatez(0)"> <input type="radio" style="position:relative;width:15px;height:15px;" /> <input type="checkbox" style="position:relative;margin-left:20px;width:15px;height:15px;" /> </body>
Attachments
Patch
(11.66 KB, patch)
2011-12-22 14:58 PST
,
Jon Lee
mitz: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jon Lee
Comment 1
2011-12-22 14:58:25 PST
Created
attachment 120387
[details]
Patch
WebKit Review Bot
Comment 2
2011-12-22 15:34:28 PST
Comment on
attachment 120387
[details]
Patch
Attachment 120387
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/10955079
New failing tests: compositing/overflow/theme-affects-visual-overflow.html
mitz
Comment 3
2011-12-22 15:40:01 PST
Comment on
attachment 120387
[details]
Patch Cool! Please figure out why the cr-linux bubble is red before committing.
mitz
Comment 4
2011-12-22 15:45:23 PST
Comment on
attachment 120387
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=120387&action=review
Just noticed something, changing to r- for now.
> Source/WebCore/rendering/RenderReplaced.cpp:-532 > - if (style()->hasAppearance()) > - // The theme may wish to inflate the rect used when repainting. > - theme()->adjustRepaintRect(this, r);
Since RenderReplaced is not a RenderBlock, how is it supposed to repaint correctly without this code?
mitz
Comment 5
2011-12-22 15:57:47 PST
Comment on
attachment 120387
[details]
Patch I’m reasonably convinced that this is okay.
Jon Lee
Comment 6
2011-12-22 16:09:11 PST
Committed
r103593
: <
http://trac.webkit.org/changeset/103593
>
Ryosuke Niwa
Comment 7
2011-12-22 19:54:52 PST
Chromium rebaseline done in
http://trac.webkit.org/changeset/103603
.
Jon Lee
Comment 8
2012-02-01 12:10:41 PST
***
Bug 77240
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug