RESOLVED FIXED 75115
Move some member variables out of ScrollElasticityController 
https://bugs.webkit.org/show_bug.cgi?id=75115
Summary Move some member variables out of ScrollElasticityController
Anders Carlsson
Reported 2011-12-22 12:51:49 PST
Move some member variables out of ScrollElasticityController
Attachments
Patch (9.67 KB, patch)
2011-12-22 12:53 PST, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-12-22 12:53:06 PST
Created attachment 120366 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-12-22 12:54:58 PST
Comment on attachment 120366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120366&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:996 > // in the opposite direction of the pin location, then we switch the > // boolean, and rubber band. That is, if we were pinned to the left, > // and we ended up scrolling to the right, we rubber band. These comments make it sound like the members are in fact related to rubberbanding. What gives?
Anders Carlsson
Comment 3 2011-12-22 12:56:27 PST
(In reply to comment #2) > (From update of attachment 120366 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120366&action=review > > > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:996 > > // in the opposite direction of the pin location, then we switch the > > // boolean, and rubber band. That is, if we were pinned to the left, > > // and we ended up scrolling to the right, we rubber band. > > These comments make it sound like the members are in fact related to rubberbanding. What gives? The comments are about when we should forward the event to the scroll elasticity controller, which is in charge of rubberbanding.
Anders Carlsson
Comment 4 2011-12-22 13:08:50 PST
Committed r103571: <http://trac.webkit.org/changeset/103571>
Note You need to log in before you can comment on or make changes to this bug.