Created attachment 120368 [details]
Comment on attachment 120368 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=120368&action=review
> + * runtime/JSString.h: Removed the single-character case because it's no
> + different from the normal case. (If we do come up with a single-character
> + optimization in future, it probably doesn't belong in JSString, anyway.)
What do you mean by no different from the normal case? Isn’t the find for a single character a different, faster function?
> What do you mean by no different from the normal case? Isn’t the find for a single character a different, faster function?
Find for a single character is faster, but the general find knows to delegate to the single-character find if possible. So, we were just duplicating logic in the general find. I'll make the ChangeLog clearer on this point.
Committed r103626: <http://trac.webkit.org/changeset/103626>