Bug 75108 – [Chromium] remove all references to the legacy accelerated 2d Canvas implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Justin Novosad]

Clean out traces of the old GLES2 2D Canvas implementation.

The legacy accelerated 2d canvas implementation was already mostly ripped-out, but there are still some dangling remnants that need cleaned out such as http://trac.webkit.org/changeset/85720

[Justin Novosad]

Created attachment 121458 [details]
Patch

[Stephen White]

Comment on attachment 121458 [details]
Patch

Yay.  r=me

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Stephen White]

Comment on attachment 121458 [details]
Patch

Removing my r+ as instructed until we get an ok from Darin.

[WebKit Review Bot]

Comment on attachment 121458 [details]
Patch

Attachment 121458 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11168043

[Stephen White]

(In reply to comment #5)
> (From update of attachment 121458 [details])
> Attachment 121458 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11168043

Hmm, looks like there are still some traces left:

Last 500 characters of output:
) out/Release/obj.target/DumpRenderTree/Tools/DumpRenderTree/chromium/WebPreferences.o
Tools/DumpRenderTree/chromium/WebPreferences.cpp: In member function 'void WebPreferences::applyTo(WebKit::WebView*)':
Tools/DumpRenderTree/chromium/WebPreferences.cpp:221: error: 'class WebKit::WebSettings' has no member named 'setLegacyAccelerated2dCanvasEnabled'

[Justin Novosad]

(In reply to comment #6)
> Hmm, looks like there are still some traces left:

D'Oh! Once again, I got burned by diff+patch because WebKit maps to multiple sub repos in Chromium...  So anoying. Good thing there's EWS. New, complete patch coming right up...

[Justin Novosad]

Created attachment 121664 [details]
Patch

[WebKit Review Bot]

Comment on attachment 121664 [details]
Patch

Rejecting attachment 121664 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
on 930 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2259.

Full output: http://queues.webkit.org/results/11186519

[Stephen White]

Comment on attachment 121664 [details]
Patch

I'm going to try setting CQ+ again to see if was perhaps just bot weirdness.

[Justin Novosad]

I just updated my client -> no conflicts.  Looks like it was just commit bot flakiness.

[WebKit Review Bot]

Comment on attachment 121664 [details]
Patch

Clearing flags on attachment: 121664

Committed r104485: <http://trac.webkit.org/changeset/104485>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.