Bug 75102 - Remove didStartRubberBand and didCompleteRubberBand callbacks
Summary: Remove didStartRubberBand and didCompleteRubberBand callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-22 11:23 PST by Anders Carlsson
Modified: 2011-12-22 11:44 PST (History)
1 user (show)

See Also:

Attachments
Patch (10.14 KB, patch)
2011-12-22 11:24 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (10.53 KB, patch)
2011-12-22 11:41 PST, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-12-22 11:23:01 PST 
Remove didStartRubberBand and didCompleteRubberBand callbacks
Comment 1 Anders Carlsson 2011-12-22 11:24:49 PST 
Created attachment 120347 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-12-22 11:26:41 PST 
Comment on attachment 120347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120347&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:-766
> -void WebChromeClient::didStartRubberBandForFrame(Frame*, const IntSize&) const
> -{
> -    m_page->drawingArea()->disableDisplayThrottling();
> -}
> -
> -void WebChromeClient::didCompleteRubberBandForFrame(Frame* frame, const IntSize& initialOverhang) const
> -{
> -    m_page->drawingArea()->enableDisplayThrottling();
> -}

Why is it OK to remove this code? Your ChangeLog doesn't explain.
Comment 3 Anders Carlsson 2011-12-22 11:41:19 PST 
Created attachment 120353 [details]
Patch
Comment 4 Anders Carlsson 2011-12-22 11:44:45 PST 
Committed r103563: <http://trac.webkit.org/changeset/103563>