Bug 75098 - [chromium] media/track/track-cue-rendering.html fails
Summary: [chromium] media/track/track-cue-rendering.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks: 104265
  Show dependency tree / graph
 
Reported: 2011-12-22 10:53 PST by Ryosuke Niwa
Modified: 2013-06-20 15:09 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch (7.50 KB, patch)
2011-12-28 16:15 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (11.40 KB, patch)
2011-12-30 11:22 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-12-22 10:53:34 PST 
media/track/track-cue-rendering.html is failing on Chromium port due to the text cue color being blue instead of transparent.
Comment 1 Ryosuke Niwa 2011-12-22 19:42:12 PST 
Note the test has been failing since http://trac.webkit.org/changeset/103486.
Comment 2 Eric Carlson 2011-12-22 22:10:32 PST 
(In reply to comment #1)
> Note the test has been failing since http://trac.webkit.org/changeset/103486.

That makes sense, http://trac.webkit.org/changeset/103486 added the cue 'color' check.
Comment 3 Eric Carlson 2011-12-28 16:13:41 PST 
The test is not making the correct check. Patch coming up.
Comment 4 Radar WebKit Bug Importer 2011-12-28 16:14:03 PST 
<rdar://problem/10630157>
Comment 5 Eric Carlson 2011-12-28 16:15:02 PST 
Created attachment 120707 [details]
Proposed patch
Comment 6 Eric Carlson 2011-12-30 11:22:49 PST 
Created attachment 120808 [details]
Updated patch

track-cue-rendering.html needed to be updated for the change to media-controls.js.
Comment 7 WebKit Review Bot 2011-12-30 13:27:34 PST 
Comment on attachment 120808 [details]
Updated patch

Clearing flags on attachment: 120808

Committed r103852: <http://trac.webkit.org/changeset/103852>
Comment 8 WebKit Review Bot 2011-12-30 13:27:39 PST 
All reviewed patches have been landed.  Closing bug.