Bug 75097 – Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView.

• Status: NEW
• Component: WebCore Misc.

[Yongjun Zhang]

We need to have a function to expose m_visuallyNoEmptyCharacterCount in FrameView.  That information would be useful to check how many RenderText characters are available in a page, for example.

[Yongjun Zhang]

Created attachment 120355 [details]
Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView.

[Sam Weinig]

Comment on attachment 120355 [details]
Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView.

View in context: https://bugs.webkit.org/attachment.cgi?id=120355&action=review

> Source/WebCore/ChangeLog:3
> +        Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView. 

I think you mean m_visuallyNonEmptyCharacterCount.

> Source/WebCore/ChangeLog:16
> +        the page is already visually no empty.  The value is reset at FrameView::reset().

Typo. no -> non.

> Source/WebCore/page/FrameView.h:-507
> +    m_visuallyNonEmptyCharacterCount += count;
>      if (m_isVisuallyNonEmpty)
>          return;
> -    m_visuallyNonEmptyCharacterCount += count;

If we are incrementing this count even after becoming visually non-empty, I am not sure the variable name makes sense any more.

[Yongjun Zhang]

(In reply to comment #2)
> (From update of attachment 120355 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120355&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView. 
> 
> I think you mean m_visuallyNonEmptyCharacterCount.
> 
> > Source/WebCore/ChangeLog:16
> > +        the page is already visually no empty.  The value is reset at FrameView::reset().
> 
> Typo. no -> non.
> 
> > Source/WebCore/page/FrameView.h:-507
> > +    m_visuallyNonEmptyCharacterCount += count;
> >      if (m_isVisuallyNonEmpty)
> >          return;
> > -    m_visuallyNonEmptyCharacterCount += count;
> 
> If we are incrementing this count even after becoming visually non-empty, I am not sure the variable name makes sense any more.

Yeah, these characters are always visually non-empty no matter when the page becomes visually non-empty or not.   How about change the variable name to be m_renderedCharacterCount?

[Yongjun Zhang]

<rdar://problem/9209360>

[Eric Seidel (no email)]

Comment on attachment 120355 [details]
Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView.

It looks like Sam was saying "please upload a new patch". :)