Bug 75085 – Web Inspector: TabbedPane should support closeable tabs, hiding tabs into drop down menu.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

TabbedPane should support closeable tabs, hiding tabs into drop down menu.

[Timothy Hatcher]

What are the plans for this? Bugs like this should communicate the "why is this needed".

[Vsevolod Vlasov]

Created attachment 120320 [details]
Patch

[Pavel Feldman]

Comment on attachment 120320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120320&action=review

> Source/WebCore/inspector/front-end/TabbedPane.js:37
> +WebInspector.TabbedPane = function(shrinkableTabs, closeableTabs)

Since you don't use these values in the constructor, prefer setShrinkableTabs and setCloseableTabs (or use the setters notation).

> Source/WebCore/inspector/front-end/inspector.css:1732
> +.tabbed-pane-header .tabbed-pane-header-tab-title {

Unless tabbed pane stops being a View, please place these into a lazily loaded tabbedPane.css.

> LayoutTests/inspector/tabbed-pane-tabs-to-show.html:38
> +    testWidthsAndHistory([50, 50, 60, 60, 70, 70], [0, 1, 2, 3, 4, 5], 370);

Too much copy-paste?

[Timothy Hatcher]

Please include the "why". It helps others working on the project that might not know your/Google's plans for things.

[Vsevolod Vlasov]

I created a meta bug for some scripts panel improvements that we plan to implement. See https://bugs.webkit.org/show_bug.cgi?id=75093.

We already have (disabled) navigator in scripts panel. Currently its behavior is somewhat inconsistent: 
 - single click on a script opens it, while single click on a folder does nothing. 
 - keyboard navigating results in all the scripts opened.

It would be better to change this behavior to open scripts on double click in tabs.

[Vsevolod Vlasov]

Committed r103555: <http://trac.webkit.org/changeset/103555>