Bug 75082 – REGRESSION(r102987): Fix the filename prefix of the generated empty .h and .cpp files for [Supplemental] IDLs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kentaro Hara]

In bug 74481, we changed generate-bindings.pl so that it generates empty .h and .cpp files for the [Supplemental] IDLs. However, the filename prefix of those .h and .cpp files is wrong.

Current behavior:
generator=JS  => JS*.h, JS*.cpp
generator=V8  => V8*.h, V8*.cpp
generator=ObjC  => ObjC*.h, ObjC*.cpp
generator=GObject  => GObject*.h, GObject*.cpp
generator=CPP  => CPP*.h, CPP*.cpp

Expected behavior:
generator=JS  => JS*.h, JS*.cpp
generator=V8  => V8*.h, V8*.cpp
generator=ObjC  => DOM*.h, DOM*.cpp
generator=GObject  => WebKitDOM*.h, WebKitDOM*.cpp
generator=CPP  => WebDOM*.h, WebDOM*.cpp

[Kentaro Hara]

Created attachment 120314 [details]
Patch

[Adam Barth]

Comment on attachment 120314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120314&action=review

> Source/WebCore/bindings/scripts/generate-bindings.pl:258
> +    my $prefix = "";
> +    if ($generator eq "JS") {
> +        $prefix = "JS";
> +    } elsif ($generator eq "V8") {
> +        $prefix = "V8";
> +    } elsif ($generator eq "ObjC") {
> +        $prefix = "DOM";
> +    } elsif ($generator eq "GObject") {
> +        $prefix = "WebKitDOM";
> +    } elsif ($generator eq "CPP") {
> +        $prefix = "WebDOM";
> +    } else {
> +        die "Unknown generator: $generator\n";
> +    }

Yuck!  Can we ask the generator what it's prefix should be rather than hardcoding a list of all the generator subclasses?

[Kentaro Hara]

Created attachment 120499 [details]
Patch

[Kentaro Hara]

Created attachment 120500 [details]
Patch

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 120314 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120314&action=review
>
> Yuck!  Can we ask the generator what it's prefix should be rather than hardcoding a list of all the generator subclasses?

Done.

[WebKit Review Bot]

Comment on attachment 120500 [details]
Patch

Clearing flags on attachment: 120500

Committed r103678: <http://trac.webkit.org/changeset/103678>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.