Bug 75079 - media/video-scales-in-media-document.html is Chromium specific
Summary: media/video-scales-in-media-document.html is Chromium specific
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 75235 (view as bug list)
Depends on: 75370
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-22 04:30 PST by Philippe Normand
Modified: 2012-01-06 16:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.93 KB, patch)
2011-12-22 10:16 PST, Dale Curtis 		no flags Details | Formatted Diff | Diff
Patch (2.42 KB, patch)
2011-12-22 15:26 PST, Dale Curtis 		no flags Details | Formatted Diff | Diff
Patch (5.56 KB, patch)
2011-12-28 14:26 PST, Dale Curtis 		no flags Details | Formatted Diff | Diff
Patch (5.56 KB, patch)
2011-12-29 18:13 PST, Dale Curtis 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-12-22 04:30:05 PST 
Test introduced in r103489 fails on GTK because the patch only updates the Chromium media controls CSS...
Comment 1 Dale Curtis 2011-12-22 10:16:12 PST 
Created attachment 120337 [details]
Patch
Comment 2 Dale Curtis 2011-12-22 10:17:24 PST 
Sorry, patch sat in the CQ forever and I had to go before it landed. I've attached the proper Skipped files.
Comment 3 Philippe Normand 2011-12-22 11:53:54 PST 
I skipped the test in GTK few hours ago.
Comment 4 Dale Curtis 2011-12-22 15:26:51 PST 
Created attachment 120392 [details]
Patch
Comment 5 Dale Curtis 2011-12-28 14:26:35 PST 
Created attachment 120699 [details]
Patch
Comment 6 Dale Curtis 2011-12-28 14:33:46 PST 
New patch moves the test into platform/chromium/media and removes the Skipped entry for GTK.
Comment 7 WebKit Review Bot 2011-12-29 10:21:34 PST 
Comment on attachment 120699 [details]
Patch

Clearing flags on attachment: 120699

Committed r103808: <http://trac.webkit.org/changeset/103808>
Comment 8 WebKit Review Bot 2011-12-29 10:21:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Andrew Wilson 2011-12-29 14:13:25 PST 
This patch broke this test on the chrome canary bots.

I notice that the test relies on media-file.js and media-test.js, which don't exist in the new directory this was moved to?
Comment 10 Dale Curtis 2011-12-29 18:13:28 PST 
Created attachment 120774 [details]
Patch
Comment 11 Dale Curtis 2011-12-29 18:15:22 PST 
Sorry, troubles working remotely. New patch up with fixed paths.
Comment 12 Andrew Wilson 2011-12-29 18:17:38 PST 
It seems like the last patch could never have worked - should we run this through the chromium layout trybots before committing this time, if you're not able to test it remotely?
Comment 13 Dale Curtis 2011-12-29 18:23:17 PST 
Not necessary, NX finally acquiesced and I was able to run the test.
Comment 14 WebKit Review Bot 2011-12-30 12:53:44 PST 
Comment on attachment 120774 [details]
Patch

Clearing flags on attachment: 120774

Committed r103850: <http://trac.webkit.org/changeset/103850>
Comment 15 WebKit Review Bot 2011-12-30 12:53:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 16 Tony Chang 2012-01-06 16:38:45 PST 
*** Bug 75235 has been marked as a duplicate of this bug. ***