Bug 75076 – Robustify UserMediaClient and UserMediaRequest lifetime handling

• Status: UNCONFIRMED
• Component: WebCore Misc.

[Adam Bergkvist]

As discussed in: https://bugs.webkit.org/show_bug.cgi?id=70897#c34

UserMediaClient should take ownership of a UserMediaRequest right away instead of passing it via UserMediaCenter so that it can notify the request if it goes away during querying of media stream sources.

[Adam Bergkvist]

Created attachment 120296 [details]
Proposed patch

[Adam Barth]

Comment on attachment 120296 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120296&action=review

> Source/WebCore/mediastream/UserMediaRequest.cpp:71
> +    m_client->registerRequest(this);

Should this be willStartRequest?

> Source/WebKit/chromium/src/UserMediaClientImpl.cpp:57
> +void UserMediaClientImpl::registerRequest(PassRefPtr<UserMediaRequest>)
> +{
> +}

Is this function supposed to do something?

[Adam Barth]

I don't quite understand what this patch is doing.  (I don't doubt that it's doing something useful---I just don't quite understand.)

[Darin Adler]

Comment on attachment 120296 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120296&action=review

> Source/WebKit/chromium/src/UserMediaClientImpl.cpp:62
> -        m_client->requestUserMedia(request, sources);
> +        m_client->requestUserMedia(PassRefPtr<UserMediaRequest>(request), sources);

Why is this typecast needed? Normally you can pass a raw pointer to an argument of type PassRefPtr without an explicit type conversion.

[Darin Adler]

Comment on attachment 120296 [details]
Proposed patch

review- because we didn’t get answers to our questions and it’s been in the review queue over a year