According to specification[1] UA should fire input and change event when spin button of number input type clicked. == References == [1] 4.10.74 Common event behaviors http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#common-event-behaviors === Excerpt === When the user agent changes the element's value on behalf of the user (e.g. as part of a form prefilling feature), the user agent must follow these steps: 1. If the input event applies, queue a task to fire a simple event that bubbles named input at the input element. 2. If the change event applies, queue a task to fire a simple event that bubbles named change at the input element.
Created attachment 127772 [details] Patch 1
Comment on attachment 127772 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=127772&action=review > Source/WebCore/html/TextFieldInputType.cpp:113 > + case DispatchInputAndChangeEvent: > + element()->dispatchFormControlInputEvent(); > + element()->dispatchFormControlChangeEvent(); > + break; > + dispatchFormControlInputEvent() executes a JavaScript event handler, and it might change the input type, or might delete the input element. So, we can't access any members of this and element(). You need to do: RefPtr<HTMLInputElement> input(element()); before event dispatching functions, and use 'input' instead of 'element()' after an event dispatching functions. > LayoutTests/fast/forms/number/spin-button-events.html:23 > +if (window.layoutTestController) { > + testIt(); > +} Please show a manual test instruction if there is no layoutTestControler.
Created attachment 127777 [details] Patch 2
Comment on attachment 127777 [details] Patch 2 ok
Comment on attachment 127777 [details] Patch 2 Clearing flags on attachment: 127777 Committed r108228: <http://trac.webkit.org/changeset/108228>
All reviewed patches have been landed. Closing bug.