WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 75025
ManualTests HTML template should be simplified
https://bugs.webkit.org/show_bug.cgi?id=75025
Summary
ManualTests HTML template should be simplified
Daniel Jalkut
Reported
2011-12-21 12:00:03 PST
During review for my patch in
bug 74775
, Ryosuke Niwa suggested some edits to the ManualTests HTML, which had originated in template.html.
https://bugs.webkit.org/show_bug.cgi?id=74775#c9
Specifically, to use an HTML5 style doctype and opening block, and to remove the empty head section.
Attachments
Patch for the recommended changes to the template file
(979 bytes, patch)
2011-12-21 12:01 PST
,
Daniel Jalkut
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Jalkut
Comment 1
2011-12-21 12:01:41 PST
Created
attachment 120208
[details]
Patch for the recommended changes to the template file
Ryosuke Niwa
Comment 2
2011-12-21 12:04:44 PST
Could you set r? and cq? flags? They indicate that the patch is up for review and you want it be landed respectively.
Daniel Jalkut
Comment 3
2011-12-21 12:15:32 PST
(In reply to
comment #2
)
> Could you set r? and cq? flags? They indicate that the patch is up for review and you want it be landed respectively.
To set those flags after the fact do I essentially have to re-attach and obsolete?
Daniel Jalkut
Comment 4
2011-12-21 12:16:11 PST
Comment on
attachment 120208
[details]
Patch for the recommended changes to the template file Add review and commit-queue flags
WebKit Review Bot
Comment 5
2011-12-22 02:23:58 PST
Comment on
attachment 120208
[details]
Patch for the recommended changes to the template file Clearing flags on attachment: 120208 Committed
r103508
: <
http://trac.webkit.org/changeset/103508
>
WebKit Review Bot
Comment 6
2011-12-22 02:24:02 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug