WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75021
Get rid of ScrollableAreaClient
https://bugs.webkit.org/show_bug.cgi?id=75021
Summary
Get rid of ScrollableAreaClient
Anders Carlsson
Reported
2011-12-21 11:36:34 PST
Get rid of ScrollableAreaClient
Attachments
Patch
(9.64 KB, patch)
2011-12-21 11:39 PST
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-12-21 11:39:51 PST
Created
attachment 120202
[details]
Patch
Anders Carlsson
Comment 2
2011-12-21 11:41:20 PST
Committed
r103421
: <
http://trac.webkit.org/changeset/103421
>
WebKit Review Bot
Comment 3
2011-12-21 11:42:46 PST
Attachment 120202
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Last 3072 characters of output: s M LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt M LayoutTests/http/tests/inspector/compiler-source-mapping.html D LayoutTests/platform/chromium/inspector/extensions/extensions-api-expected.txt M LayoutTests/ChangeLog M Source/cmake/WebKitFS.cmake M Source/WebKit/chromium/WebKit.gyp M Source/WebKit/chromium/ChangeLog M Source/WebKit/chromium/scripts/generate_devtools_extension_api.py M Source/WebKit/chromium/scripts/concatenate_js_files.py A Source/WebKit/chromium/src/js/DevToolsExtensionAPI.js M Source/WebKit/chromium/src/js/DevTools.js M Source/WebKit/chromium/WebKit.gypi M Source/WebCore/WebCore.exp.in M Source/WebCore/ChangeLog M Source/WebCore/page/FrameView.cpp M Source/WebCore/page/ScrollingCoordinator.cpp M Source/WebCore/page/ScrollingCoordinator.h D Source/WebCore/platform/ScrollableAreaClient.h M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/platform/ScrollableArea.cpp M Source/WebCore/platform/ScrollView.cpp M Source/WebCore/platform/ScrollView.h M Source/WebCore/WebCore.gypi M Source/WebCore/inspector/front-end/DebuggerPresentationModel.js M Source/WebCore/inspector/front-end/ExtensionAPI.js M Source/WebCore/inspector/front-end/CompilerSourceMapping.js M Source/WebCore/inspector/front-end/utilities.js M Source/WebCore/inspector/front-end/ExtensionServer.js M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebKit2/ChangeLog M Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm M Source/WebKit2/UIProcess/API/mac/WKConnection.mm M Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm M Source/WebKit2/UIProcess/API/qt/tests/html/scroll.html M Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp A Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/favicon.html A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/favicon.png A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/favicon2.html A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/small-favicon.png M Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro M Source/WebKit2/UIProcess/API/qt/qwebiconimageprovider.cpp M Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp M Source/CMakeLists.txt M Tools/Scripts/build-webkit M Tools/Scripts/webkitdirs.pm M Tools/ChangeLog M CMakeLists.txt W: -empty_dir: trunk/LayoutTests/platform/chromium/inspector/extensions/extensions-api-expected.txt W: -empty_dir: trunk/Source/WebCore/platform/ScrollableAreaClient.h
r103421
= 4e370a7735460be70844a3369d7d2a04865ca5a3 (refs/remotes/origin/master) It seems that I cannot create a rebase-apply directory, and I wonder if you are in the middle of patch application or another rebase. If that is not the case, please rm -fr /mnt/git/webkit-style-queue/.git/rebase-apply and run me again. I am stopping in case you still have something valuable there. rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 158. If any of these errors are false positives, please file a bug against check-webkit-style.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug