The following tests will exhibit failures after Skia is rolled to 2918. The underlying cause needs to be found and fixed. Some of them are due to different bounding volumes for degenerate paths, while others are due to changes to fill behavior. Regressions: Unexpected image and text mismatch : (4) svg/custom/dasharrayOrigin.svg = IMAGE+TEXT svg/custom/marker-empty-path.svg = IMAGE+TEXT svg/custom/marker-overflow-clip.svg = IMAGE+TEXT Regressions: Unexpected image mismatch : (5) svg/W3C-SVG-1.1/paths-data-01-t.svg = IMAGE svg/custom/animate-path-morphing.svg = IMAGE svg/custom/dynamic-svg-document-creation.svg = IMAGE svg/custom/js-update-path-changes.svg = IMAGE svg/custom/js-update-path-removal.svg = IMAGE Regressions: Unexpected text diff mismatch : (4) fast/canvas/canvas-fillPath-alpha-shadow.html = TEXT fast/canvas/canvas-fillPath-gradient-shadow.html = TEXT fast/canvas/canvas-fillPath-pattern-shadow.html = TEXT svg/custom/subpaths-moveto-only-rendering.svg = TEXT
Created attachment 120199 [details] Patch
Attachment 120199 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource M ChangeLog M LayoutTests/http/tests/inspector/extensions-test.js M LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt M LayoutTests/http/tests/inspector/compiler-source-mapping.html D LayoutTests/platform/chromium/inspector/extensions/extensions-api-expected.txt M LayoutTests/ChangeLog M Source/cmake/WebKitFS.cmake M Source/WebKit/chromium/WebKit.gyp M Source/WebKit/chromium/ChangeLog M Source/WebKit/chromium/scripts/generate_devtools_extension_api.py M Source/WebKit/chromium/scripts/concatenate_js_files.py A Source/WebKit/chromium/src/js/DevToolsExtensionAPI.js M Source/WebKit/chromium/src/js/DevTools.js M Source/WebKit/chromium/WebKit.gypi M Source/WebCore/ChangeLog M Source/WebCore/WebCore.gypi M Source/WebCore/inspector/front-end/DebuggerPresentationModel.js M Source/WebCore/inspector/front-end/ExtensionAPI.js M Source/WebCore/inspector/front-end/CompilerSourceMapping.js M Source/WebCore/inspector/front-end/utilities.js M Source/WebCore/inspector/front-end/ExtensionServer.js M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebKit2/ChangeLog M Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm M Source/WebKit2/UIProcess/API/mac/WKConnection.mm M Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm M Source/WebKit2/UIProcess/API/qt/tests/html/scroll.html M Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp A Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/favicon.html A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/favicon.png A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/favicon2.html A Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/small-favicon.png M Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro M Source/WebKit2/UIProcess/API/qt/qwebiconimageprovider.cpp M Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp M Source/CMakeLists.txt M Tools/Scripts/build-webkit M Tools/Scripts/webkitdirs.pm M Tools/ChangeLog M CMakeLists.txt W: -empty_dir: trunk/LayoutTests/platform/chromium/inspector/extensions/extensions-api-expected.txt r103419 = 379600103b90a003194b6ed0d12c9f255cd60b16 (refs/remotes/origin/master) It seems that I cannot create a rebase-apply directory, and I wonder if you are in the middle of patch application or another rebase. If that is not the case, please rm -fr /mnt/git/webkit-style-queue/.git/rebase-apply and run me again. I am stopping in case you still have something valuable there. rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 158. If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 120209 [details] Patch
Comment on attachment 120209 [details] Patch Attachment 120209 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10996076 New failing tests: compositing/iframes/scrolling-iframe.html http/tests/inspector/resource-tree/resource-tree-document-url.html compositing/iframes/iframe-resize.html
Comment on attachment 120209 [details] Patch Clearing flags on attachment: 120209 Committed r103510: <http://trac.webkit.org/changeset/103510>
All reviewed patches have been landed. Closing bug.
Re-opening, as these changes must be reverted when the underlying issues are fixed.
Created attachment 121138 [details] Patch Skia has rolled far enough to have the fix for these tests.
Comment on attachment 121138 [details] Patch Clearing flags on attachment: 121138 Committed r104148: <http://trac.webkit.org/changeset/104148>