Bug 75018 - Don't recreate scrollbar layers whenever the frame view size changes
Summary: Don't recreate scrollbar layers whenever the frame view size changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks: 72078
  Show dependency tree / graph
 
Reported: 2011-12-21 11:20 PST by Anders Carlsson
Modified: 2012-01-05 10:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2011-12-21 11:24 PST, Anders Carlsson 		simon.fraser: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-12-21 11:20:17 PST 
Don't recreate scrollbar layers whenever the frame view size changes
Comment 1 Anders Carlsson 2011-12-21 11:24:56 PST 
Created attachment 120197 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-21 11:25:54 PST 
Attachment 120197 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource

It seems that I cannot create a rebase-apply directory, and
I wonder if you are in the middle of patch application or another
rebase.  If that is not the case, please
	rm -fr /mnt/git/webkit-style-queue/.git/rebase-apply
and run me again.  I am stopping in case you still have something
valuable there.
rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 158.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2011-12-21 11:26:42 PST 
Comment on attachment 120197 [details]
Patch

You should fix m_layerForScrollCorner too.
Comment 4 Anders Carlsson 2011-12-21 11:29:07 PST 
Committed r103419: <http://trac.webkit.org/changeset/103419>
Comment 5 James Robinson 2011-12-21 13:40:28 PST 
Looks good to me too, thanks for fixing this!
Comment 6 Ryosuke Niwa 2011-12-22 10:03:57 PST 
It appears that this patch caused compositing/iframes/scrolling-iframe.html to fail on Chromium:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fiframes%2Fscrolling-iframe.html
Comment 7 James Robinson 2011-12-22 10:34:11 PST 
It looks like it just flipped the order of the horizontal and vertical scrollbar layers in the GraphicsLayer tree on this test, so it just needs a rebaseline.
Comment 8 Ryosuke Niwa 2011-12-22 10:39:13 PST 
(In reply to comment #7)
> It looks like it just flipped the order of the horizontal and vertical scrollbar layers in the GraphicsLayer tree on this test, so it just needs a rebaseline.

Yeah, we just figured that out. Will do rebaseline in a minute.