Pointed out by Darin Adler in https://bugs.webkit.org/show_bug.cgi?id=74909#c4 > - Document::m_formElementsWithState should change to hold HTMLFormControlElement* instead of Element*, and all the functions should likewise change. I think the looser type is a remnant of WML support.
Created attachment 120155 [details] Patch
Comment on attachment 120155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120155&action=review Love it! > Source/WebCore/dom/Document.cpp:4319 > String value; > if (!elementWithState->shouldSaveAndRestoreFormControlState()) > continue; Unrelated to this patch, but we should move "String value;" below the continue to avoid creating the empty string unnecessarily.
Thank you for reviewing. I'll move "String value" and land the patch. (In reply to comment #2) > > Source/WebCore/dom/Document.cpp:4319 > > String value; > > if (!elementWithState->shouldSaveAndRestoreFormControlState()) > > continue; > > Unrelated to this patch, but we should move "String value;" below the continue to avoid creating the empty string unnecessarily.
Committed r103491: <http://trac.webkit.org/changeset/103491>