Bug 74996 - [Forms] Add OVERRIDE to WebCore/html/*InputType.h
Summary: [Forms] Add OVERRIDE to WebCore/html/*InputType.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 23:04 PST by yosin
Modified: 2011-12-21 01:48 PST (History)
2 users (show)

See Also:

Attachments
Patch 1 (50.57 KB, patch)
2011-12-21 00:10 PST, yosin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2011-12-20 23:04:07 PST 
We would like to have "override" method modifier (by using OVERRIDE macro) for WebCore/html/*InputType.h to make our code robust.

There are 30 files:
1 BaseButtonInputType.h
2 BaseCheckableInputType.h
3 BaseDateAndTimeInputType.h
4 BaseTextInputType.h
5 ButtonInputType.h
6 CheckboxInputType.h
7 ColorInputType.h
8 DateInputType.h
9 DateTimeInputType.h
10 DateTimeLocalInputType.h
11 EmailInputType.h
12 FileInputType.h
13 HiddenInputType.h
14 ImageInputType.h
15 InputType.h
16 IsIndexInputType.h
17 MonthInputType.h
18 NumberInputType.h
19 PasswordInputType.h
20 RadioInputType.h
21 RangeInputType.h
22 ResetInputType.h
23 SearchInputType.h
24 SubmitInputType.h
25 TelephoneInputType.h
26 TextFieldInputType.h
27 TextInputType.h
28 TimeInputType.h
29 URLInputType.h
30 WeekInputType.h
Comment 1 yosin 2011-12-21 00:10:13 PST 
Created attachment 120153 [details]
Patch 1
Comment 2 Kent Tamura 2011-12-21 00:27:27 PST 
Comment on attachment 120153 [details]
Patch 1

ok
Comment 3 WebKit Review Bot 2011-12-21 01:48:02 PST 
Comment on attachment 120153 [details]
Patch 1

Clearing flags on attachment: 120153

Committed r103400: <http://trac.webkit.org/changeset/103400>
Comment 4 WebKit Review Bot 2011-12-21 01:48:06 PST 
All reviewed patches have been landed.  Closing bug.