Bug 74995 – [EFL][WK2] Implement context menu for EFL port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Implement missing ContextMenuEfl class in order to support WK2's context menu. Because WK2's context menu still needs WebCore's context menu implementation.
And of course, this patch also can be used for WK1 without CROSS_PLATFORM_CONTEXT_MENU option.

Now, Bug 74179 supports context menu as well. But, the patch is to support context menu using CROSS_PLATFORM_CONTEXT_MENUS option. I think we also need to support context menu when CROSS_PLATFORM_CONTEXT_MENUS is disabled.

[Gyuyoung Kim]

Created attachment 120146 [details]
Patch

[Gyuyoung Kim]

In addition, I use Vector class for PlatformMenuDescription. I didn't feel like using efl library for this.

[Gyuyoung Kim]

Created attachment 120149 [details]
Patch

[Martin Robinson]

Comment on attachment 120149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120149&action=review

> Source/WebCore/platform/efl/ContextMenuItemEfl.cpp:103
>  void ContextMenuItem::setChecked(bool)
>  {
> -    notImplemented();
> +    m_platformDescription.checked = checked;

Shouldn't this use the argument?

> Source/WebCore/platform/efl/ContextMenuItemEfl.cpp:114
>  void ContextMenuItem::setEnabled(bool)
>  {
> -    notImplemented();
> +    m_platformDescription.enabled = enabled;
>  }

Ditto.

[Gyuyoung Kim]

Created attachment 120278 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #4)
> (From update of attachment 120149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120149&action=review
> 
> > Source/WebCore/platform/efl/ContextMenuItemEfl.cpp:103
> >  void ContextMenuItem::setChecked(bool)
> >  {
> > -    notImplemented();
> > +    m_platformDescription.checked = checked;
> 
> Shouldn't this use the argument?
> 
> > Source/WebCore/platform/efl/ContextMenuItemEfl.cpp:114
> >  void ContextMenuItem::setEnabled(bool)
> >  {
> > -    notImplemented();
> > +    m_platformDescription.enabled = enabled;
> >  }
> 
> Ditto.

Oops, my mistake. Fix them.

[Gyuyoung Kim]

Created attachment 120279 [details]
Patch

[Gyuyoung Kim]

Created attachment 120540 [details]
Patch

[WebKit Review Bot]

Comment on attachment 120540 [details]
Patch

Clearing flags on attachment: 120540

Committed r103702: <http://trac.webkit.org/changeset/103702>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.