Bug 74992 - In prepare-ChangeLog, replace constant global variables with "use constant"
Summary: In prepare-ChangeLog, replace constant global variables with "use constant"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 73531 74994
  Show dependency tree / graph
 
Reported: 2011-12-20 21:45 PST by Kentaro Hara
Modified: 2011-12-22 02:33 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.23 KB, patch)
2011-12-20 21:50 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for commit (8.22 KB, patch)
2011-12-21 00:17 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for commit (8.24 KB, patch)
2011-12-21 00:21 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-12-20 21:45:47 PST 
I found that we need to completely remove (even constant) global variables from prepare-ChangeLog in order to load it by LoadAsModule.pm (bug 74836). Thus we need to replace constant global variables in prepare-ChangeLog with "use constant".
Comment 1 Kentaro Hara 2011-12-20 21:50:56 PST 
Created attachment 120141 [details]
Patch
Comment 2 Ryosuke Niwa 2011-12-21 00:09:06 PST 
Comment on attachment 120141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120141&action=review

Looks sane to me.

> Tools/Scripts/prepare-ChangeLog:320
> +    my $command = GIT . " log --max-count=1 --pretty=\"format:%an\" \"$gitCommit\"";

Why don't we use single quotations here?
Comment 3 Kentaro Hara 2011-12-21 00:17:46 PST 
Created attachment 120156 [details]
patch for commit
Comment 4 Kentaro Hara 2011-12-21 00:21:15 PST 
Created attachment 120157 [details]
patch for commit
Comment 5 WebKit Review Bot 2011-12-21 00:54:39 PST 
Comment on attachment 120157 [details]
patch for commit

Clearing flags on attachment: 120157

Committed r103399: <http://trac.webkit.org/changeset/103399>