RESOLVED FIXED Bug 74992
In prepare-ChangeLog, replace constant global variables with "use constant" 
https://bugs.webkit.org/show_bug.cgi?id=74992
Summary In prepare-ChangeLog, replace constant global variables with "use constant"
Kentaro Hara
Reported 2011-12-20 21:45:47 PST
I found that we need to completely remove (even constant) global variables from prepare-ChangeLog in order to load it by LoadAsModule.pm (bug 74836). Thus we need to replace constant global variables in prepare-ChangeLog with "use constant".
Attachments
Patch (8.23 KB, patch)
2011-12-20 21:50 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for commit (8.22 KB, patch)
2011-12-21 00:17 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for commit (8.24 KB, patch)
2011-12-21 00:21 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-20 21:50:56 PST
Created attachment 120141 [details] Patch
Ryosuke Niwa
Comment 2 2011-12-21 00:09:06 PST
Comment on attachment 120141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120141&action=review Looks sane to me. > Tools/Scripts/prepare-ChangeLog:320 > + my $command = GIT . " log --max-count=1 --pretty=\"format:%an\" \"$gitCommit\""; Why don't we use single quotations here?
Kentaro Hara
Comment 3 2011-12-21 00:17:46 PST
Created attachment 120156 [details] patch for commit
Kentaro Hara
Comment 4 2011-12-21 00:21:15 PST
Created attachment 120157 [details] patch for commit
WebKit Review Bot
Comment 5 2011-12-21 00:54:39 PST
Comment on attachment 120157 [details] patch for commit Clearing flags on attachment: 120157 Committed r103399: <http://trac.webkit.org/changeset/103399>
Note You need to log in before you can comment on or make changes to this bug.