When the page is destroyed the notification controller does not tell the client that it is being destroyed. The client gets leaked.
Created attachment 120999 [details]
Comment on attachment 120999 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=120999&action=review
It may be worth adding comments to the ChangeLogs for the ports that are getting empty implementations of the new client method briefly mentioning why they're empty rather than doing what WebKit/mac and WebKit2 are doing (different ownership model for the Client object presumably?).
> + [WK2] Leak of WebNotificationClient when page is destroyed
Seems like the [WK2] should be removed since it appears to also leak on WebKit1 for Mac.
Will do. Thanks for the review.
Commited r103975: http://trac.webkit.org/changeset/103975