Bug 74980 - Leak of WebNotificationClient when page is destroyed
Summary: Leak of WebNotificationClient when page is destroyed
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Jon Lee
Keywords: InRadar
Depends on:
Reported: 2011-12-20 17:19 PST by Jon Lee
Modified: 2012-01-03 15:43 PST (History)
3 users (show)

See Also:

Patch (17.11 KB, patch)
2012-01-03 14:32 PST, Jon Lee
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2011-12-20 17:19:00 PST
When the page is destroyed the notification controller does not tell the client that it is being destroyed. The client gets leaked.
Comment 1 Radar WebKit Bug Importer 2011-12-20 17:19:32 PST
Comment 2 Jon Lee 2012-01-03 14:32:18 PST
Created attachment 120999 [details]
Comment 3 Mark Rowe (bdash) 2012-01-03 14:48:39 PST
Comment on attachment 120999 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=120999&action=review

It may be worth adding comments to the ChangeLogs for the ports that are getting empty implementations of the new client method briefly mentioning why they're empty rather than doing what WebKit/mac and WebKit2 are doing (different ownership model for the Client object presumably?).

> Source/WebCore/ChangeLog:3
> +        [WK2] Leak of WebNotificationClient when page is destroyed

Seems like the [WK2] should be removed since it appears to also leak on WebKit1 for Mac.
Comment 4 Jon Lee 2012-01-03 14:57:42 PST
Will do. Thanks for the review.
Comment 5 Jon Lee 2012-01-03 15:28:21 PST
Commited r103975: http://trac.webkit.org/changeset/103975