Bug 74963 – Don't crash on the second time VideoLayerChromium::createCCVideoLayer() is called

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ami Fischman]

r103298 assumed that VideoLayerChromium would only create a CCVideoLayerImpl once, but that's wrong because the CC*LayerImpl tree can be dropped and recreated.  Support this.

[Ami Fischman]

Created attachment 120095 [details]
Patch

[James Robinson]

Comment on attachment 120095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120095&action=review

> Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h:59
> +    VideoFrameProvider* m_provider;

would you mind adding a comment here indicating that this class should never dereference this pointer, but simply pass it on to the CCVideoLayerImpl ?

[Ami Fischman]

Created attachment 120103 [details]
Patch

[Ami Fischman]

(In reply to comment #2)
> (From update of attachment 120095 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120095&action=review
> 
> > Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h:59
> > +    VideoFrameProvider* m_provider;
> 
> would you mind adding a comment here indicating that this class should never dereference this pointer, but simply pass it on to the CCVideoLayerImpl ?

Done.  Thanks for the quick review.

[WebKit Review Bot]

Comment on attachment 120103 [details]
Patch

Clearing flags on attachment: 120103

Committed r103370: <http://trac.webkit.org/changeset/103370>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.