Bug 74948 - NamedNodeMap: Get rid of declCount().
Summary: NamedNodeMap: Get rid of declCount().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 12:22 PST by Andreas Kling
Modified: 2011-12-22 10:44 PST (History)
0 users

See Also:


Attachments
Patch (2.52 KB, patch)
2011-12-20 12:29 PST, Andreas Kling
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-20 12:22:52 PST
We don't need NamedNodeMap::declCount() since we're already tracking the number of mapped attributes via the declAdded()/declRemoved() methods.
Comment 1 Andreas Kling 2011-12-20 12:29:01 PST
Created attachment 120059 [details]
Patch
Comment 2 Andreas Kling 2011-12-20 14:54:51 PST
Comment on attachment 120059 [details]
Patch

Looking closer, I'm not sure this is correct. There might be cases where we have a mapped attribute with a null decl in the attribute map. Need to investigate further.
Comment 3 Andreas Kling 2011-12-22 09:49:11 PST
Comment on attachment 120059 [details]
Patch

Never mind, this is correct AFAICT. I had misunderstood the role of a mapped attribute's style declaration.
Comment 4 Andreas Kling 2011-12-22 10:44:33 PST
Committed r103557: <http://trac.webkit.org/changeset/103557>