Bug 74947 - [chromium] enable WPO for WebCore libs in official builds
Summary: [chromium] enable WPO for WebCore libs in official builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 11:53 PST by Tony Chang
Modified: 2011-12-20 13:45 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.44 KB, patch)
2011-12-20 11:54 PST, Tony Chang 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-12-20 11:53:01 PST 
[chromium] enable WPO for WebCore libs in official builds
Comment 1 Tony Chang 2011-12-20 11:54:05 PST 
Created attachment 120050 [details]
Patch
Comment 2 Tony Chang 2011-12-20 11:55:57 PST 
The optimize change won't do anything until http://codereview.chromium.org/8983002/ is landed and rolled into webkit.  It's harmless until then.
Comment 3 James Robinson 2011-12-20 12:03:13 PST 
Comment on attachment 120050 [details]
Patch

RS=me
Comment 4 Nico Weber 2011-12-20 12:04:15 PST 
Comment on attachment 120050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120050&action=review

lgtm

> Source/WebCore/WebCore.gyp/WebCore.gyp:49
> +    'enable_wexit_time_destructors': 1,

If this works, it's great. I hadn't tried building tests, so I don't know if there's anything left there.

I guess the bots will tell you :-)
Comment 5 James Robinson 2011-12-20 12:06:05 PST 
Comment on attachment 120050 [details]
Patch

Resetting flag that Nico cleared
Comment 6 Tony Chang 2011-12-20 12:15:22 PST 
(In reply to comment #4)
> (From update of attachment 120050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120050&action=review
> > Source/WebCore/WebCore.gyp/WebCore.gyp:49
> > +    'enable_wexit_time_destructors': 1,
> 
> If this works, it's great. I hadn't tried building tests, so I don't know if there's anything left there.
> 
> I guess the bots will tell you :-)

I re-ran gyp with this change (and clang=1) and verified that the generated .mk files have -Wexit-time-destructors.  I'm assume if that if it works for enable_wexit_time_destructors, then it will also work for optimize.
Comment 7 Tony Chang 2011-12-20 13:45:36 PST 
Committed r103348: <http://trac.webkit.org/changeset/103348>