Bug 74947 – [chromium] enable WPO for WebCore libs in official builds

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

[chromium] enable WPO for WebCore libs in official builds

[Tony Chang]

Created attachment 120050 [details]
Patch

[Tony Chang]

The optimize change won't do anything until http://codereview.chromium.org/8983002/ is landed and rolled into webkit.  It's harmless until then.

[James Robinson]

Comment on attachment 120050 [details]
Patch

RS=me

[Nico Weber]

Comment on attachment 120050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120050&action=review

lgtm

> Source/WebCore/WebCore.gyp/WebCore.gyp:49
> +    'enable_wexit_time_destructors': 1,

If this works, it's great. I hadn't tried building tests, so I don't know if there's anything left there.

I guess the bots will tell you :-)

[James Robinson]

Comment on attachment 120050 [details]
Patch

Resetting flag that Nico cleared

[Tony Chang]

(In reply to comment #4)
> (From update of attachment 120050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120050&action=review
> > Source/WebCore/WebCore.gyp/WebCore.gyp:49
> > +    'enable_wexit_time_destructors': 1,
> 
> If this works, it's great. I hadn't tried building tests, so I don't know if there's anything left there.
> 
> I guess the bots will tell you :-)

I re-ran gyp with this change (and clang=1) and verified that the generated .mk files have -Wexit-time-destructors.  I'm assume if that if it works for enable_wexit_time_destructors, then it will also work for optimize.

[Tony Chang]

Committed r103348: <http://trac.webkit.org/changeset/103348>