WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74945
HTMLMediaElement::configureTextTrackDisplay is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=74945
Summary
HTMLMediaElement::configureTextTrackDisplay is unnecessary
Eric Carlson
Reported
2011-12-20 11:32:00 PST
HTMLMediaElement hides and shows the cue display element tracks are shown and hidden, but MediaControlRootElement::updateTextTrackDisplay already hides and shows the display element when cues are necessary. Both are not necessary.
Attachments
Proposed patch
(1.56 KB, patch)
2011-12-20 12:17 PST
,
Eric Carlson
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2011-12-20 11:33:20 PST
<
rdar://problem/10608586
>
Eric Carlson
Comment 2
2011-12-20 12:17:22 PST
Created
attachment 120058
[details]
Proposed patch
Darin Adler
Comment 3
2011-12-21 10:34:55 PST
Comment on
attachment 120058
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=120058&action=review
B
> Source/WebCore/ChangeLog:8 > + Nothing to test, just removing redundant code.
But what existing test covers this code?
Eric Carlson
Comment 4
2011-12-21 12:24:32 PST
http://trac.webkit.org/changeset/103428
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug